![]() However, I am not sure what the commit c710c9b MC-35554: Orders with Zero Payment Information required are Closed after being invoiced that introduced the bug wanted to achieve with this change, so it might have other side effects reverting this change with this patch. I tested it with discounts of 0%, 40%, 50%, 90% and 100%Īll tests worked fine with my setting. ![]() + $invoice->setGrandTotal($invoice->getGrandTotal() - $totalDiscountAmount) $invoice->setBaseGrandTotal($baseGrandTotal) $baseGrandTotal = $invoice->getBaseGrandTotal() - $baseTotalDiscountAmount getBaseGrandTotal() - $baseTotalDiscountAmount $grandTotal = $invoice->getGrandTotal() - $totalDiscountAmount getGrandTotal() - $totalDiscountAmount $invoice->setBaseDiscountAmount(-$baseTotalDiscountAmount) $invoice->setDiscountAmount(-$totalDiscountAmount) +++ -71,12 +71,11 class Discount extends AbstractTotal a/Model/Order/Invoice/Total/Discount.php ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channelĭiff -git a/Model/Order/Invoice/Total/Discount.php b/Model/Order/Invoice/Total/Discount.php □ You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ![]() If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. □ The triage of issues happens in the queue order. □ You can find the schedule on the Magento Community Calendar page. Community Contributions Triage is a public meeting. ⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Join Magento Community Engineering Slack and ask your questions in #github channel.Please, add a comment to assign the issue: I am working on this To deploy vanilla Magento instance on our environment, please, add a comment to the give me 2.4-develop instance - upcoming 2.4.x releaseįor more details, please, review the Magento Contributor Assistant documentation. Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To help us process this issue please make sure that you provided the following information: Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.Severity: S0 - Affects critical data or functionality and leaves users without workaround.This information will help during Confirmation and Issue triage processes. ![]() Please provide Severity assessment for the Issue as Reporter. We now have the scenario that the invoices show a grand total > 0 which is not resolvable for accounting since these amounts were never received from the customer.īasically the same issue occurs if the discount is not 100%, just the amounts differ of course. The usage of $totalDiscountTaxCompensation is IMHO wrong when using these settings.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |